Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Linux GPIO logging #20093

Merged

Conversation

costas-basdekis
Copy link
Contributor

Description

When enabling GPIO_LOGGING, a code that uses a deprecated version of a macro (MAX3 vs _MAX) is used, that causes a compilation error.

Also updated .gitignore to ignore *_log.csv files in the top directory

Benefits

Fixes GPIO logging

Configurations

#define MOTHERBOARD BOARD_LINUX_RAMPS
#define GPIO_LOGGING

I haven't added a test case, to not increase the duration of tests, but could easily add one

@costas-basdekis
Copy link
Contributor Author

Also a question: is there a way to visualise the output of IOLogger?

How do you usually use it?

@p3p
Copy link
Member

p3p commented Nov 10, 2020

I'm pretty sure no one other than me when I added this platform has ever used it, so there isn't really a response to usually ^^, but when I was using it I used KST2 (https://kst-plot.kde.org/) to visualise the position data in realtime from the csv file,

My intention was to replace this platform with the simulator I'm working on, and a separate cut down Linux realtime platform, what are you currently using it for?

@thinkyhead thinkyhead added PR: Bug Fix T: HAL & APIs Topic related to the HAL and internal APIs. labels Nov 11, 2020
@thinkyhead thinkyhead merged commit 3b68e44 into MarlinFirmware:bugfix-2.0.x Nov 11, 2020
@thinkyhead thinkyhead changed the title Fix GPIO logging Fix Linux GPIO logging Nov 11, 2020
@costas-basdekis costas-basdekis deleted the fix-gpio-logging branch November 11, 2020 04:41
@costas-basdekis
Copy link
Contributor Author

@p3p I was playing running the Linux implementation on my machine, and I was wondering if there was a way to see what actually happens with the pins. I'd be interested to hear what else you've done on that front, I was thinking maybe a frontend that shows pin state & history, just for the fun of it.

Also, how do you set pins? I tried G28 but of course there's no actual end stops and it just emergency stops.

ustsv pushed a commit to ustsv/Marlin that referenced this pull request Nov 12, 2020
FhlostonParadise pushed a commit to FhlostonParadise/Marlin that referenced this pull request Nov 21, 2020
Kannix2005 pushed a commit to Kannix2005/Marlin-1 that referenced this pull request Dec 7, 2020
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request Dec 9, 2020
tharts pushed a commit to tharts/Marlin that referenced this pull request Jan 6, 2021
dpreed pushed a commit to dpreed/Marlin_2.0.x that referenced this pull request Feb 5, 2021
dpreed pushed a commit to dpreed/Marlin_2.0.x that referenced this pull request Feb 5, 2021
kpishere pushed a commit to kpishere/Marlin that referenced this pull request Feb 19, 2021
W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021
thinkyhead added a commit to thinkyhead/Marlin that referenced this pull request Apr 28, 2021
thinkyhead added a commit to thinkyhead/Marlin that referenced this pull request Apr 29, 2021
thinkyhead added a commit that referenced this pull request Apr 30, 2021
Co-authored-by: Scott Lahteine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix T: HAL & APIs Topic related to the HAL and internal APIs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants